upgrade: media, event-listener, rootless, static-store and utils package upgrade for Solid 2.0#849
Draft
davedbase wants to merge 3 commits intosolidjs-community:nextfrom
Draft
upgrade: media, event-listener, rootless, static-store and utils package upgrade for Solid 2.0#849davedbase wants to merge 3 commits intosolidjs-community:nextfrom
davedbase wants to merge 3 commits intosolidjs-community:nextfrom
Conversation
🦋 Changeset detectedLatest commit: b4699b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 50 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
This PR now encompasses more than media since they are all very dependent on each other. There's augments for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the media primitive and all of its workspace dependencies to Solid.js
2.0.0-beta.7. The package is bumped to3.0.0as a breaking major release.What changed
@solid-primitives/mediaisServerimport moved fromsolid-js/web→@solidjs/websolid-js@^2.0.0-beta.7and@solidjs/web@^2.0.0-beta.7onMountremoved, assertions made synchronousclassarray form, splitcreateEffect)@solid-primitives/utilsonMount→onSettledincreateHydratableSignalsharedConfig.context→sharedConfig.hydratingfor hydration detectionequalFn→isEqual,INTERNAL_OPTIONSusespureWrite: true(wasinternal: true)AccessorArray<T>removed (gone from Solid 2.0) — replaced withAccessor<T>[]@solid-primitives/static-storegetListener→getObserver,{ internal: true }→{ pureWrite: true }batch()calls removed — Solid 2.0 batches automatically on microtaskssharedConfig.hydrating+onSettledincreateHydratableStaticStore@solid-primitives/rootlessbatchremoved fromcreateRootPool,sharedConfig.hydratingincreateHydratableSingletonRoot@solid-primitives/event-listenerisServerimports updated to@solidjs/webcreateEventListenerandcreateRenderEffectconverted to the required Solid 2.0 split compute/apply pattern — listeners now attach in the apply phase with cleanup returned as a functioneventListenerdirective likewise converted; no longer usesonCleanupinside an effectNotes
@solidjs/web@latestpoints toexperimental.0which is incompatible with beta.7 — the correct version is@solidjs/web@2.0.0-beta.7(thenextdist-tag).